-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add integration test github workflow action #453
Merged
jim-wang-intel
merged 8 commits into
intel-retail:main
from
jim-wang-intel:add-github-action-integration-tests
Jan 12, 2024
Merged
feat: add integration test github workflow action #453
jim-wang-intel
merged 8 commits into
intel-retail:main
from
jim-wang-intel:add-github-action-integration-tests
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
requested review from
brian-intel,
antoniomtz,
NeethuES-intel,
vli11 and
ejlee3
January 11, 2024 21:20
jim-wang-intel
changed the title
feat: add integrationn test github workflow action
feat: add integration test github workflow action
Jan 11, 2024
vli11
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jim-wang-intel
force-pushed
the
add-github-action-integration-tests
branch
from
January 12, 2024 18:59
772bd52
to
8a8d001
Compare
jim-wang-intel
requested review from
vli11,
antoniomtz,
NeethuES-intel and
ejlee3
January 12, 2024 18:59
@brian-intel i think it may be working now as long as the runner can do the beginning clean up for the builds directory on the host machine. |
jim-wang-intel
force-pushed
the
add-github-action-integration-tests
branch
5 times, most recently
from
January 12, 2024 22:16
706fa4b
to
5f6532b
Compare
Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]> fix: remove -i from docker run for github action runner Signed-off-by: Jim Wang <[email protected]>
…dless github action runner to work Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
force-pushed
the
add-github-action-integration-tests
branch
from
January 12, 2024 22:25
5f6532b
to
aa79e42
Compare
brian-intel
approved these changes
Jan 12, 2024
vli11
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Issue this PR will close
close: #issue_number
Anything the reviewer should know when reviewing this PR?
Test Instructions if applicable
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )