Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integration test github workflow action #453

Conversation

jim-wang-intel
Copy link
Contributor

@jim-wang-intel jim-wang-intel commented Jan 11, 2024

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/automated-self-checkout/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )

@jim-wang-intel jim-wang-intel changed the title feat: add integrationn test github workflow action feat: add integration test github workflow action Jan 11, 2024
Copy link
Contributor

@vli11 vli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-wang-intel jim-wang-intel marked this pull request as draft January 12, 2024 15:42
@jim-wang-intel jim-wang-intel force-pushed the add-github-action-integration-tests branch from 772bd52 to 8a8d001 Compare January 12, 2024 18:59
@jim-wang-intel jim-wang-intel marked this pull request as ready for review January 12, 2024 18:59
@jim-wang-intel jim-wang-intel added 2.0 enhancement New feature or request labels Jan 12, 2024
@jim-wang-intel
Copy link
Contributor Author

@brian-intel i think it may be working now as long as the runner can do the beginning clean up for the builds directory on the host machine.

@jim-wang-intel jim-wang-intel force-pushed the add-github-action-integration-tests branch 5 times, most recently from 706fa4b to 5f6532b Compare January 12, 2024 22:16
Signed-off-by: Jim Wang <[email protected]>

fix: remove -i from docker run for github action runner

Signed-off-by: Jim Wang <[email protected]>
…dless github action runner to work

Signed-off-by: Jim Wang <[email protected]>
@jim-wang-intel jim-wang-intel force-pushed the add-github-action-integration-tests branch from 5f6532b to aa79e42 Compare January 12, 2024 22:25
Copy link
Contributor

@vli11 vli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-wang-intel jim-wang-intel merged commit 398f68c into intel-retail:main Jan 12, 2024
6 checks passed
@jim-wang-intel jim-wang-intel deleted the add-github-action-integration-tests branch January 17, 2024 01:51
@jim-wang-intel jim-wang-intel linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Test Actions
3 participants