Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orca: remove hardcode redis_password from branch-2.0 #7019

Merged
merged 3 commits into from
Dec 20, 2022
Merged

orca: remove hardcode redis_password from branch-2.0 #7019

merged 3 commits into from
Dec 20, 2022

Conversation

liu-shaojun
Copy link
Contributor

@liu-shaojun liu-shaojun commented Dec 16, 2022 •
edited
Loading

Description

This submission removes hardcoded redis_password from python/orca/src/bigdl/orca/ray/ray_on_spark_context.py from branch-2.0

  • if users want to specify redis_password, they can add key value into extra_params to launch ray: extra_params={"redis-password": "xxxxxx"}
  • if redis_password is not defined in extra_params, the default redis password defined in ray will be used.

Related PR: #5649

@liu-shaojun liu-shaojun changed the title orca: remove hardcode redis_password orca: remove hardcode redis_password from branch-2.0 Dec 16, 2022
@liu-shaojun liu-shaojun mentioned this pull request Dec 19, 2022
Merged
@liu-shaojun liu-shaojun merged commit 4d6c379 into intel-analytics:branch-2.0 Dec 20, 2022
@liu-shaojun liu-shaojun deleted the wip/fix_redis_pwd branch December 20, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorysdj glorysdj Awaiting requested review from glorysdj

@sgwhat sgwhat Awaiting requested review from sgwhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liu-shaojun