Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano : Update pytorch inference QuickStart with InferenceOptimizer #5899

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Nano : Update pytorch inference QuickStart with InferenceOptimizer #5899

merged 3 commits into from
Sep 26, 2022

Conversation

rnwang04
Copy link
Contributor

@rnwang04 rnwang04 commented Sep 22, 2022

Description

Update https://bigdl.readthedocs.io/en/latest/doc/Nano/QuickStart/pytorch_inference.html with InferenceOptimizer

1. Why the change?

As we have deprecated Trainer.trace / Trainer.quantize, we need to change our documentation too.

2. User API changes

No change

3. Summary of the change

  • Update Pytorch inference QuickStart

4. How to test?

accuracy_criterion={'relative': 0.01, 'higher_is_better': True},
approach='static',
max_trials=10,
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than these changes, we may add a warning note to tell our previous users(if any), Trainer's API will be deprecated in futyre.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@TheaperDeng TheaperDeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnwang04 rnwang04 merged commit cd52feb into intel-analytics:main Sep 26, 2022
liu-shaojun pushed a commit that referenced this pull request Mar 25, 2024
…5899)

* replace Trainer with InferenceOptimizer

* add warning note for deprecation of trainer.trace / trainer.quantize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants