Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 4642, fix DBFS file path problem on Dataricks #5679

Merged
merged 2 commits into from
Sep 8, 2022
Merged

fix issue 4642, fix DBFS file path problem on Dataricks #5679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
708867d
fix issue 4642
PatrickkZ Sep 7, 2022
47d13ad
parse model_dir
PatrickkZ Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/dllib/src/bigdl/dllib/utils/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ def mkdirs(path):


def is_local_path(path):
if path.startswith("/dbfs"):
return False
parse_result = urlparse(path)
return len(parse_result.scheme.lower()) == 0 or parse_result.scheme.lower() == "file"

Expand Down
8 changes: 7 additions & 1 deletion python/orca/src/bigdl/orca/learn/tf2/pyspark_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@
logger = logging.getLogger(__name__)


def parse_model_dir(model_dir):
if model_dir and model_dir.startswith("dbfs:/"):
model_dir = "/dbfs/" + model_dir[len("dbfs:/"):]
return model_dir


class SparkTFEstimator():
def __init__(self,
model_creator,
Expand Down Expand Up @@ -83,7 +89,7 @@ def __init__(self,
invalidInputError(False,
"Please do not specify batch_size in config. Input batch_size in the"
" fit/evaluate function of the estimator instead.")
self.model_dir = model_dir
self.model_dir = parse_model_dir(model_dir)
master = sc.getConf().get("spark.master")
if not master.startswith("local"):
logger.info("For cluster mode, make sure to use shared filesystem path "
Expand Down