Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pentest Issue: remove hardcode credentials #5649

Merged
merged 10 commits into from
Sep 13, 2022
Merged

Pentest Issue: remove hardcode credentials #5649

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae5380d
remove hardcode credentials
liu-shaojun Sep 6, 2022
fac51f1
update
liu-shaojun Sep 6, 2022
d39096e
add orca ut to PR_validation.yml
liu-shaojun Sep 6, 2022
2f075cc
use redis_paasword in extra_params otherwise use the default password…
liu-shaojun Sep 7, 2022
b637aed
refine code
liu-shaojun Sep 7, 2022
850ea23
update
liu-shaojun Sep 8, 2022
efabbcb
typo
liu-shaojun Sep 8, 2022
fe11da9
remove orca ut from pr validation
liu-shaojun Sep 8, 2022
d6eb9fa
update
liu-shaojun Sep 13, 2022
8addaad
update
liu-shaojun Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/orca/src/bigdl/orca/ray/ray_on_spark_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ def _start_ray_services(iter):
class RayOnSparkContext(object):
_active_ray_context = None

def __init__(self, sc, redis_port=None, password="123456", object_store_memory=None,
def __init__(self, sc, redis_port=None, password=None, object_store_memory=None,
liu-shaojun marked this conversation as resolved.
Show resolved Hide resolved
verbose=False, env=None, extra_params=None, include_webui=True,
num_ray_nodes=None, ray_node_cpu_cores=None, system_config=None):
"""
Expand All @@ -346,7 +346,7 @@ def __init__(self, sc, redis_port=None, password="123456", object_store_memory=N
:param sc: An instance of SparkContext.
:param redis_port: The redis port for the ray head node. Default is None.
The value would be randomly picked if not specified.
:param password: The password for redis. Default to be "123456" if not specified.
:param password: The password for redis. Default to be "None" if not specified.
:param object_store_memory: The memory size for ray object_store in string.
This can be specified in bytes(b), kilobytes(k), megabytes(m) or gigabytes(g).
For example, "50b", "100k", "250m", "30g".
Expand Down