1. changes for abs and add layer according to pr 2. checkin AbsCriiterion and AddConstant layer #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iterion and AddConstant layer
yiheng
reviewed
Oct 26, 2016
| override def updateGradInput(input: Tensor[T], gradOutput: Tensor[T]): Tensor[T] = { | ||
| gradInput.resizeAs(input).copy(gradOutput) | ||
|
|
||
| val inputArray = input.storage().array() |
There was a problem hiding this comment.
please check input.isContigous and gradOutput.isContigous .
Or the code will be wrong
| } | ||
|
|
||
| override def reset(): Unit = { | ||
| initMethod match { |
There was a problem hiding this comment.
Let's don't give user other option here
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
…-analytics#45) * refactor * refactor python * refactor scala * add remark for torch layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.