bug fix: DLModel prediction #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure DLModel.train=False when predicting in pipeline API
hhbyyh
reviewed
Jan 18, 2018
| @@ -391,7 +391,8 @@ class DLModel[@specialized(Float, Double) T: ClassTag]( | |||
| val localBatchSize = $(batchSize) | |||
|
|
|||
| val resultRDD = dataFrame.rdd.mapPartitions { rowIter => | |||
| val localModel = modelBroadCast.value() | |||
| // call the evaluate method to enable DLModel.train=False during the predict process | |||
| val localModel = modelBroadCast.value().evaluate() | |||
There was a problem hiding this comment.
Is it better if we move evaluate before model broadcasting?
| .setBatchSize(nRecords) | ||
| .setOptimMethod(new LBFGS[Float]()) | ||
| .setLearningRate(0.1) | ||
| .setMaxEpoch(maxEpoch) |
| @@ -91,6 +91,27 @@ class DLEstimatorSpec extends FlatSpec with Matchers with BeforeAndAfter { | |||
| assert(correct > nRecords * 0.8) | |||
| } | |||
|
|
|||
| "An DLEstimator" should "throws exception when DLModel is predicting with DLModel.train=True" in { | |||
There was a problem hiding this comment.
Shall we use intercept exception in this unit test? The content and the title does not quite match.
|
Hi @hhbyyh, |
|
Thanks for the update. |
qiuxin2012
approved these changes
Feb 7, 2018
|
jenkins passed |
yiheng
pushed a commit
to yiheng/BigDL
that referenced
this pull request
Feb 13, 2018
* bug fix: DLModel prediction (#4) Make sure DLModel.train=False when predicting in pipeline API * 1. broadcast transformer in DLModel.transform ; 2. remove useless ut
Le-Zheng
pushed a commit
to Le-Zheng/BigDL
that referenced
this pull request
Oct 20, 2021
* rebase * revert automl readme
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
* rebase * revert automl readme
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
* rebase * revert automl readme
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
* rebase * revert automl readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
manual test