Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove falcon support and related UT #12656

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

MeouSker77
Copy link
Contributor

@MeouSker77 MeouSker77 commented Jan 6, 2025

Description

Remove falcon support as its support is out of date and there are some errors in it.

We choose to remove it instead of fixing or upgrading it because there is no user still using it.

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...

@MeouSker77
Copy link
Contributor Author

Copy link
Contributor

@Oscilloscope98 Oscilloscope98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,117 +0,0 @@
#
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change a model for this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add new UT after finishing upgrade, in a new way

@MeouSker77 MeouSker77 merged commit ea65e4f into intel-analytics:main Jan 7, 2025
1 check passed
@MeouSker77 MeouSker77 deleted the remove-falcon-support branch January 7, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants