Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPU] Update C++ example with repetition_penalty & update Python code accordingly #12528

Conversation

Oscilloscope98
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 commented Dec 11, 2024

Description

https://github.com/analytics-zoo/nano/issues/1741#issuecomment-2535539498

Work with https://github.com/intel-analytics/llm.cpp/pull/719

  • Update C++ example with repetition_penalty
  • Fit python (cpp backend) simple generate with updated C++ API

@Oscilloscope98 Oscilloscope98 changed the title [NPU] Update C++ example with repetition_penalty & update Python example accordingly [NPU] Update C++ example with repetition_penalty & update Python code accordingly Dec 11, 2024
Copy link
Contributor

@plusbang plusbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rnwang04 rnwang04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oscilloscope98
Copy link
Contributor Author

Merge for now. Will raise further PRs for any comments :)

@Oscilloscope98 Oscilloscope98 merged commit dbaf4ab into intel-analytics:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants