Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oneccl-binding.patch #12377

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update oneccl-binding.patch #12377

merged 3 commits into from
Nov 11, 2024

Conversation

liu-shaojun
Copy link
Contributor

Description

1. Why the change?

Update oneccl-binding.patch to use environment variable IPEX_LLM_CCL_ENABLE_NATIVE_WAIT to decide whether to use stream.get_native().wait();

2. User API changes

3. Summary of the change

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...

5. New dependencies

  • New Python dependencies
    - Dependency1
    - Dependency2
    - ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...

@liu-shaojun liu-shaojun changed the title Add files via upload Update oneccl-binding.patch Nov 11, 2024
Copy link
Contributor

@gc-fu gc-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liu-shaojun liu-shaojun merged commit c92d76b into main Nov 11, 2024
@liu-shaojun liu-shaojun deleted the ccl_patch branch November 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants