Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama 3.1/3.2 support compresskv #12347

Merged
merged 6 commits into from
Nov 6, 2024
Merged

llama 3.1/3.2 support compresskv #12347

merged 6 commits into from
Nov 6, 2024

Conversation

cyita
Copy link
Contributor

@cyita cyita commented Nov 6, 2024 •
edited
Loading

Description

llama 3.1/3.2 support compresskv.

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

  • Application test

5. New dependencies

  • New Python dependencies
    - Dependency1
    - Dependency2
    - ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...

@cyita cyita requested a review from MeouSker77 November 6, 2024 08:17
@cyita cyita requested a review from Oscilloscope98 November 6, 2024 08:35
@cyita
Copy link
Contributor Author

cyita commented Nov 6, 2024

For llama3.2 1b, I will disable compresskv since the performance improvement is not obvious.

Oscilloscope98
Oscilloscope98 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once PR validation is passed :)

@cyita
Copy link
Contributor Author

cyita commented Nov 6, 2024

PR validation: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/11700267684

@cyita cyita merged commit f24352a into intel-analytics:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oscilloscope98 Oscilloscope98 Oscilloscope98 approved these changes

@MeouSker77 MeouSker77 MeouSker77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyita @MeouSker77 @Oscilloscope98