[NPU] Support Baichuan groupwise & gw code refactor #12337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyita
changed the title
cyita
changed the title
cyita
changed the title
plusbang
approved these changes
Nov 8, 2024
| mlp_module_names = ["down_proj", "up_proj", "gate_proj"] | ||
| if ( | ||
| isinstance(module, (Qwen2Attention, LlamaAttention)) | ||
| or module.__class__.__name__ in ['MiniCPMAttention', 'Attention'] | ||
| or module.__class__.__name__ in ['MiniCPMAttention'] |
There was a problem hiding this comment.
Shall we also update the following check of module.__class__.__name__ in ['MiniCPMMLP', 'MLP']?
| @@ -115,8 +124,10 @@ def __init__( | |||
| attention_mask = self.create_input_op((self.batch_size, 1, 1, self.max_seq_len + 1), | |||
| dtype=np.int64) | |||
| else: | |||
| attention_mask = self.create_input_op((self.batch_size, 1, self.seq_len, self.seq_len), | |||
| dtype=np.int64) | |||
| # attention_mask = self.create_input_op((self.batch_size, 1, self.seq_len, | |||
There was a problem hiding this comment.
Please remove this directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODOs:
1. Why the change?
2. User API changes
3. Summary of the change
4. How to test?
1234). And paste your action link here once it has been successfully finished.5. New dependencies
- Dependency1
- Dependency2
- ...
- Dependency1 and license1
- Dependency2 and license2
- ...