Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qwen layernorm as input #12309

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Qwen layernorm as input #12309

merged 2 commits into from
Nov 4, 2024

Conversation

hkvision
Copy link
Contributor

Seems layernorm as input is faster for qwen-cw

@cyita
Copy link
Contributor

cyita commented Nov 1, 2024 •
edited
Loading

Also add parser.add_argument("--quantization_group_size", type=int, default=0) and quantization_group_size=args.quantization_group_size, in this PR?

@hkvision
Copy link
Contributor Author

hkvision commented Nov 1, 2024

Also add parser.add_argument("--quantization_group_size", type=int, default=0) and quantization_group_size=args.quantization_group_size, in this PR?

Sure.

cyita
cyita approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@cyita cyita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkvision hkvision merged commit c8679ad into intel-analytics:main Nov 4, 2024
1 check passed
@hkvision hkvision deleted the qwen-perf branch November 4, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyita cyita cyita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkvision @cyita