Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for qlora finetuning on GPU #12298

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

JinheTang
Copy link
Contributor

@JinheTang JinheTang commented Oct 30, 2024

  • Fix error during qlora finetuning evaluation stage
    image

  • update readme about mpirun installation

@rnwang04 rnwang04 self-requested a review October 30, 2024 07:55
self.weight.qtype, input_seq_size)
if self.weight.qtype == NF4:
result = xe_linear.forward_new(x_2d, self.weight.data.view(torch.uint8),
self.weight.qtype, input_seq_size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the code style.

@@ -23,6 +23,8 @@ pip install bitsandbytes scipy
source /opt/intel/oneapi/setvars.sh # necessary to run before installing deepspeed
pip install git+https://github.com/microsoft/DeepSpeed.git@78c518e
pip install git+https://github.com/intel/intel-extension-for-deepspeed.git@ec33277
# install mpirun
Copy link
Contributor

@rnwang04 rnwang04 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# (optional) install mpirun to run multi-card finetuning

@rnwang04 rnwang04 changed the title bugfix for qlora 100 step error bugfix for qlora finetuning on GPU Oct 30, 2024
Copy link
Contributor

@rnwang04 rnwang04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnwang04 rnwang04 merged commit 46d8300 into intel-analytics:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants