Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor attention_softmax #12295

Merged
merged 1 commit into from
Oct 30, 2024
Merged

refactor attention_softmax #12295

merged 1 commit into from
Oct 30, 2024

Conversation

MeouSker77
Copy link
Contributor

Description

remove training condition in attention_softmax

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...

@MeouSker77
Copy link
Contributor Author

PR validation: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/11585812369

@MeouSker77 MeouSker77 requested a review from rnwang04 October 30, 2024 02:51
rnwang04
rnwang04 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@rnwang04 rnwang04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeouSker77 MeouSker77 merged commit 540eaeb into intel-analytics:main Oct 30, 2024
1 check passed
@MeouSker77 MeouSker77 deleted the refactor-attention-softmax branch October 30, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnwang04 rnwang04 rnwang04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeouSker77 @rnwang04