small fix #11978
Merged
small fix #11978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgwhat
reviewed
Aug 30, 2024
| @@ -40,7 +40,7 @@ | |||
| parser.add_argument("--max-prompt-len", type=int, default=960) | |||
| parser.add_argument("--disable-transpose-value-cache", action="store_true", default=False) | |||
| parser.add_argument("--intra-pp", type=int, default=2) | |||
| parser.add_argument("--inter-pp", type=int, default=2) | |||
| parser.add_argument("--inter-pp", type=int, default=4) | |||
There was a problem hiding this comment.
set inter-pp and intra-pp to None?
cyita
pushed a commit
to cyita/BigDL
that referenced
this pull request
Sep 5, 2024
* fix * meet comment
cranechu0131
pushed a commit
to cranechu0131/ipex-llm
that referenced
this pull request
Sep 9, 2024
* fix * meet comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Why the change?
small fix of default value of inter-pp / intra-pp : https://github.com/intel-analytics/llm-npu/issues/17#issuecomment-2320661222
2. User API changes
3. Summary of the change
4. How to test?
1234). And paste your action link here once it has been successfully finished.