Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added accelerate upgrade in ollama UI quickstart #11948

Merged
merged 1 commit into from
Aug 28, 2024
Merged

added accelerate upgrade in ollama UI quickstart #11948

merged 1 commit into from
Aug 28, 2024

Conversation

JinheTang
Copy link
Contributor

accelerate version specified in bigdl-core-cpp is fallen behind and will result in incompatibility with transformers when running open-webui for ollama, therefore requires an upgrade before running start_windows.bat

@JinheTang
Copy link
Contributor Author

@rnwang04 pls kindly review :)

rnwang04
rnwang04 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@rnwang04 rnwang04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnwang04 rnwang04 merged commit ec67ee7 into intel-analytics:main Aug 28, 2024
@jason-dai
Copy link
Contributor

  1. Is it specific to Open WebUI, or shall we upgrade [cpp] dependency?
  2. Instead of using the latest version, we should probably specify the particular versions that we have tested
  3. We should add these versions into requirements.txt?

@rnwang04
Copy link
Contributor

  1. Is it specific to Open WebUI, or shall we upgrade [cpp] dependency?
  2. Instead of using the latest version, we should probably specify the particular versions that we have tested
  3. We should add these versions into requirements.txt?

OK, we will do more test with transformers / accelerate version, and evaluate if we can directly upgrade and specify their version in [cpp] dependency.

@jason-dai
Copy link
Contributor

  1. Is it specific to Open WebUI, or shall we upgrade [cpp] dependency?
  2. Instead of using the latest version, we should probably specify the particular versions that we have tested
  3. We should add these versions into requirements.txt?

OK, we will do more test with transformers / accelerate version, and evaluate if we can directly upgrade and specify their version in [cpp] dependency.

You should always specify the particular versions that you have tested; using latest versions will break the compatibility in future.

@JinheTang JinheTang deleted the accelerate-version-specification branch August 28, 2024 07:36
@rnwang04
Copy link
Contributor

  1. Is it specific to Open WebUI, or shall we upgrade [cpp] dependency?
  2. Instead of using the latest version, we should probably specify the particular versions that we have tested
  3. We should add these versions into requirements.txt?

OK, we will do more test with transformers / accelerate version, and evaluate if we can directly upgrade and specify their version in [cpp] dependency.

You should always specify the particular versions that you have tested; using latest versions will break the compatibility in future.

Got it, we will pay attention to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnwang04 rnwang04 rnwang04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JinheTang @jason-dai @rnwang04