Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor npu_model #11927

Merged
merged 8 commits into from
Aug 27, 2024
Merged

refactor npu_model #11927

merged 8 commits into from
Aug 27, 2024

Conversation

lzivan
Copy link
Contributor

@lzivan lzivan commented Aug 26, 2024

Description

  • replace enable_mp parameter as optimize_model
  • customize default value of inter_pp and intra_pp by model type

lzivan added 6 commits August 22, 2024 17:41
add recommendation for npu driver version of 32.0.100.2540
1. replace enable_mp parameter as optimize_model
2. customize default value of inter_pp and intra_pp by model type
@plusbang
Copy link
Contributor

Please fix code style and add descriptions about parameter of from_pretrained

@@ -55,7 +55,7 @@
trust_remote_code=True,
attn_implementation="eager",
load_in_low_bit="sym_int4",
enable_mp=True,
optimize_modelin=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this typo also.

@jason-dai
Copy link
Contributor

Let's fix the typos and merge this PR @plusbang @lzivan

@plusbang plusbang merged commit 6c3eb1e into intel-analytics:main Aug 27, 2024
1 check passed
@plusbang
Copy link
Contributor

Let's fix the typos and merge this PR @plusbang @lzivan

Have merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants