-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support streaming for lookup generation #11922
Merged
Oscilloscope98
merged 9 commits into
intel-analytics:main
from
Oscilloscope98:lookup-streaming-support
Aug 26, 2024
Merged
Support streaming for lookup generation #11922
Oscilloscope98
merged 9 commits into
intel-analytics:main
from
Oscilloscope98:lookup-streaming-support
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oscilloscope98
changed the title
Lookup streaming support
Support streaming for lookup generation
Aug 26, 2024
cyita
reviewed
Aug 26, 2024
…pport input length threshold judgement for directly input with input_ids
cyita
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jason-dai
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/analytics-zoo/nano/issues/1589#issuecomment-2309918037
inputs = tokenizer([input_str], return_tensors="pt")
, and generate throughgenerate(**inputs, ...)
TODO: Further optimize lookup stream generation speed if possible