Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vllm qwen2 series models #11879

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix vllm qwen2 series models #11879

merged 1 commit into from
Aug 21, 2024

Conversation

gc-fu
Copy link
Contributor

@gc-fu gc-fu commented Aug 21, 2024

Description

Qwen2 series model like Qwen2-1.5B-Instruct model will set tie_word_embedding to true, which will lead to errors.

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...

5. New dependencies

  • New Python dependencies
    - Dependency1
    - Dependency2
    - ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...

@gc-fu
Copy link
Contributor Author

gc-fu commented Aug 21, 2024

https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/10482489912

@gc-fu gc-fu requested a review from xiangyuT August 21, 2024 02:54
xiangyuT
xiangyuT approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@xiangyuT xiangyuT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gc-fu gc-fu merged commit 537c0d2 into main Aug 21, 2024
1 check passed
@gc-fu gc-fu deleted the fix-vllm-qwen2 branch August 21, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyuT xiangyuT xiangyuT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gc-fu @xiangyuT