Update Llama2 multi-processes example #11852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plusbang
approved these changes
Aug 19, 2024
| import random | ||
| idx = random.randint(0, 2) | ||
| prompt = prompts[idx] | ||
| prompt = get_prompt(args.prompt, [], system_prompt=DEFAULT_SYSTEM_PROMPT) |
There was a problem hiding this comment.
I think we also need to update sample output in readme. Other LGTM.
jason-dai
reviewed
Aug 19, 2024
| - `--n-predict N_PREDICT`: argument defining the max number of tokens to predict. It is default to be `32`. | ||
| - `--max-output-len MAX_OUTPUT_LEN`: Defines the maximum sequence length for both input and output tokens. It is default to be `1024`. | ||
| - `--max-prompt-len MAX_PROMPT_LEN`: Defines the maximum number of tokens that the input prompt can contain. It is default to be `128`. |
There was a problem hiding this comment.
why 128? Maybe 512 or 768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the prompt handling section in the llama2 example for #11787.
1. Why the change?
Support users in providing their own prompts to improve response quality.
2. User API changes
N/A
3. Summary of the change
4. How to test?