Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gemma2 runtime error caused by sliding window #11788

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

rnwang04
Copy link
Contributor

@rnwang04 rnwang04 commented Aug 14, 2024

Description

1. Why the change?

#11758
we found gemma2 will raise error when context is longer than sliding window size.

2. User API changes

No change.

3. Summary of the change

  • Fix sdp logic of gemma2 to handle with sliding window

4. How to test?

  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.

@rnwang04
Copy link
Contributor Author

@rnwang04 rnwang04 merged commit 43cca3b into intel-analytics:main Aug 14, 2024
1 check passed
@rnwang04 rnwang04 deleted the gemma2_fix branch August 14, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants