Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to use out-of-tree GPU driver #11761

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

liu-shaojun
Copy link
Contributor

@liu-shaojun liu-shaojun commented Aug 12, 2024

Description

Revert #11728 to use out-of-tree GPU driver since Arc performance with out-of-tree driver is better than upstream driver. See performance gap in https://github.com/analytics-zoo/nano/issues/1563#issuecomment-2282981842

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...

5. New dependencies

  • New Python dependencies
    - Dependency1
    - Dependency2
    - ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...


sudo apt-get install -y gawk libc6-dev udev\
# Install Compute Runtime
sudo apt-get install -y udev\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space becore \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add trouble shooting in case out of tree driver is conflicted with kernel driver.

If encountered random core dump when running with GPU, please remove out of tree driver.

Copy link
Contributor

@qiyuangong qiyuangong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liu-shaojun liu-shaojun merged commit fac4c01 into intel-analytics:main Aug 12, 2024
@liu-shaojun liu-shaojun deleted the driver branch August 12, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants