Phi3 support compresskv #11733
Merged
Phi3 support compresskv #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-dai
reviewed
Aug 9, 2024
| @@ -485,7 +485,7 @@ def update_past_key_value(past_key_value, key_states, value_states, | |||
| return key_states, value_states | |||
|
|
|||
|
|
|||
| def should_use_compresskv(x: torch.Tensor, prompt_len: int): | |||
| def should_use_compresskv(x: torch.Tensor, prompt_len: int, sliding_window: int=None): | |||
|
See comments above; otherwise LGTM |
rnwang04
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Phi3 support compresskv.
1. Why the change?
2. User API changes
3. Summary of the change
4. How to test?
1234). And paste your action link here once it has been successfully finished.5. New dependencies
- Dependency1
- Dependency2
- ...
- Dependency1 and license1
- Dependency2 and license2
- ...