Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly spr & core perf test #11470

Closed
wants to merge 4 commits into from

Conversation

liu-shaojun
Copy link
Contributor

@liu-shaojun liu-shaojun commented Jul 1, 2024

Description

1. Why the change?

This submission install pydantic for spr & core perf test to fix nightly perf test failure:
https://github.com/intel-analytics/ipex-llm/actions/runs/9700292272/job/26771341907
https://github.com/intel-analytics/ipex-llm/actions/runs/9700292272/job/26771342167

@liu-shaojun liu-shaojun changed the title pip install pydantic for spr&core perf test Fix nightly spr & core perf test Jul 1, 2024
@liu-shaojun liu-shaojun requested a review from plusbang July 1, 2024 01:55
@plusbang
Copy link
Contributor

plusbang commented Jul 1, 2024

It seems that import error of pydantic exists when install [all] option, maybe we also need to fix here or add pydantic in setup.py.

@Oscilloscope98
Copy link
Contributor

I don't think pydantic is a required option for cpu, as it is required for pp serving. We may update here :)

@liu-shaojun liu-shaojun closed this Jul 1, 2024
@liu-shaojun liu-shaojun deleted the fix_perf branch July 1, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants