Remove chatglm_C Module to Eliminate LGPL Dependency #11178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-shaojun
changed the title
liu-shaojun
changed the title
MeouSker77
approved these changes
May 31, 2024
sgwhat
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Why the change?
Issue: https://github.com/analytics-zoo/nano/issues/1406
This submission aims to remove the chatglm_C module, which introduced the ngsolve package (licensed under LGPL, a Weak Copyleft license), to meet the requirements of OSPDT. The chatglm._C module was used for native int4, which has now been deprecated, so this change will not have a significant impact.
During our preparations for OSPDT, we conducted scans using BDBA and identified several wheel packages that include the ngsolve package, such as
ipex_llm/libs/chatglm_C.cpython-39-x86_64-linux-gnu.so. It's worth noting thatngsolveis licensed under LGPL, which is a Weak Copyleft license. We have been advised to minimize the use of LGPL licenses as much as possible.