Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pip install to use --extra-index-url for ipex package #10557

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Update pip install to use --extra-index-url for ipex package #10557

merged 9 commits into from
Mar 28, 2024

Conversation

chtanch
Copy link
Contributor

@chtanch chtanch commented Mar 27, 2024 •
edited
Loading

Description

Update ipex-llm install from
pip install --pre --upgrade ipex-llm[xpu] -f https://developer.intel.com/ipex-whl-stable-xpu
to
pip install --pre --upgrade ipex-llm[xpu] --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/
in readmes, code comments, and python/llm/example/CPU/Deepspeed-AutoTP/install.sh

Update
pip install oneccl_bind_pt==2.1.100 -f https://developer.intel.com/ipex-whl-stable-xpu
to
pip install oneccl_bind_pt==2.1.100 --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/

@chtanch chtanch changed the title Update to pip install --extra-index-url for readthedocs Update to pip install --extra-index-url Mar 27, 2024
@chtanch chtanch force-pushed the update_pip_install branch from 0e6da75 to d532efa Compare March 27, 2024 06:35
@chtanch chtanch marked this pull request as ready for review March 27, 2024 06:35
@chtanch chtanch changed the title Update to pip install --extra-index-url Update pip install to use --extra-index-url for ipex package Mar 27, 2024
jason-dai
jason-dai reviewed Mar 27, 2024
View reviewed changes
docs/readthedocs/source/doc/LLM/Overview/install_gpu.md Outdated
@@ -393,15 +393,15 @@ We recommend using [miniconda](https://docs.conda.io/en/latest/miniconda.html) t
conda create -n llm python=3.9
conda activate llm

pip install --pre --upgrade ipex-llm[xpu] -f https://developer.intel.com/ipex-whl-stable-xpu
pip install --pre --upgrade ipex-llm[xpu] --extra-index-url https://developer.intel.com/ipex-whl-stable-xpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link is incorrect; see https://ipex-llm.readthedocs.io/en/latest/doc/LLM/Quickstart/install_windows_gpu.html#install-ipex-llm

@jason-dai
Copy link
Contributor

Description

Update ipex-llm install from pip install --pre --upgrade ipex-llm[xpu] -f https://developer.intel.com/ipex-whl-stable-xpu to pip install --pre --upgrade ipex-llm[xpu] --extra-index-url https://developer.intel.com/ipex-whl-stable-xpu in readmes, code comments, and python/llm/example/CPU/Deepspeed-AutoTP/install.sh

Update pip install oneccl_bind_pt==2.1.100 -f https://developer.intel.com/ipex-whl-stable-xpu to pip install oneccl_bind_pt==2.1.100 --extra-index-url https://developer.intel.com/ipex-whl-stable-xp

The url is incorrect; see https://ipex-llm.readthedocs.io/en/latest/doc/LLM/Quickstart/install_windows_gpu.html#install-ipex-llm

@chtanch
Copy link
Contributor Author

chtanch commented Mar 27, 2024

Updated https://developer.intel.com/ipex-whl-stable-xpu to https://pytorch-extension.intel.com/release-whl/stable/xpu/us/

@chtanch
Copy link
Contributor Author

chtanch commented Mar 27, 2024

Update github actions to pip install from https://pytorch-extension.intel.com/release-whl/stable/xpu/us/ as well?

jason-dai
jason-dai reviewed Mar 27, 2024
View reviewed changes
python/llm/README.md Outdated
@@ -125,7 +125,7 @@ You may install **`ipex-llm`** on Intel GPU as follows:
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file hasn't been removed @chtanch

jason-dai
jason-dai reviewed Mar 27, 2024
View reviewed changes
python/llm/example/CPU/Deepspeed-AutoTP/install.sh Outdated
@@ -12,7 +12,7 @@ mkdir -p /opt/intel/oneccl
mv ./_install/env /opt/intel/oneccl
# 2. install torch and ipex
pip install torch==2.1.0
pip install intel_extension_for_pytorch==2.1.0 -f https://developer.intel.com/ipex-whl-stable-cpu
pip install intel_extension_for_pytorch==2.1.0 --extra-index-url https://developer.intel.com/ipex-whl-stable-cpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this url is incorrect

jason-dai
jason-dai reviewed Mar 27, 2024
View reviewed changes
docs/readthedocs/source/doc/LLM/Overview/install_gpu.md Outdated
@@ -56,7 +56,7 @@ The easiest ways to install `ipex-llm` is the following commands:
conda create -n llm python=3.9 libuv
conda activate llm

pip install --pre --upgrade ipex-llm[xpu] -f https://developer.intel.com/ipex-whl-stable-xpu
pip install --pre --upgrade ipex-llm[xpu] --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add CN link, either in a separate tab or in the note.

@jason-dai
Copy link
Contributor

Description

Update ipex-llm install from pip install --pre --upgrade ipex-llm[xpu] -f https://developer.intel.com/ipex-whl-stable-xpu to pip install --pre --upgrade ipex-llm[xpu] --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/ in readmes, code comments, and python/llm/example/CPU/Deepspeed-AutoTP/install.sh

Update pip install oneccl_bind_pt==2.1.100 -f https://developer.intel.com/ipex-whl-stable-xpu to pip install oneccl_bind_pt==2.1.100 --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/

Need to add CN link as well, either in a separate tab or a note

@chtanch chtanch force-pushed the update_pip_install branch from 7d9f195 to 133e023 Compare March 27, 2024 10:36
@chtanch chtanch force-pushed the update_pip_install branch from 133e023 to ed3c061 Compare March 27, 2024 10:45
@chtanch
Copy link
Contributor Author

chtanch commented Mar 27, 2024

Applied changes in comments.

Preview - https://chtanch-docs.readthedocs.io/en/update_pip_install/doc/LLM/Overview/install_gpu.html

hkvision
hkvision approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@hkvision hkvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge it after removing the README.

@hkvision
Copy link
Contributor

Applied changes in comments.

Preview - https://chtanch-docs.readthedocs.io/en/update_pip_install/doc/LLM/Overview/install_gpu.html

The documents look nice and no issue observed.

@hkvision hkvision merged commit 1c5eb14 into intel-analytics:main Mar 28, 2024
96 checks passed
@chtanch chtanch deleted the update_pip_install branch March 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-dai jason-dai jason-dai left review comments

@hkvision hkvision hkvision approved these changes

@glorysdj glorysdj Awaiting requested review from glorysdj glorysdj is a code owner

@liu-shaojun liu-shaojun Awaiting requested review from liu-shaojun liu-shaojun is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chtanch @jason-dai @hkvision