Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serving] Fix fastchat breaks #10548

Merged
merged 2 commits into from
Mar 26, 2024
Merged

[Serving] Fix fastchat breaks #10548

merged 2 commits into from
Mar 26, 2024

Conversation

gc-fu
Copy link
Contributor

@gc-fu gc-fu commented Mar 26, 2024

Description

Fix the fastchat error caused by migration errors.

1. Why the change?

To fix the following three problems:

  1. README.md errors
  2. file name errors
  3. Change name from bigdl_worker to ipex_llm_worker

@gc-fu gc-fu requested a review from glorysdj March 26, 2024 08:43
glorysdj
glorysdj approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@glorysdj glorysdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jason-dai
jason-dai reviewed Mar 26, 2024
View reviewed changes
python/llm/src/ipex_llm/serving/fastchat/README.md Outdated
```

For a full list of accepted arguments, you can refer to the main method of the `ipex_worker.py`
For a full list of accepted arguments, you can refer to the main method of the `ipex_llm_worker.py`

#### IPEX vLLM model worker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPEX-LLM vLLM worker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, the other two titles have also been changed from IPEX to IPEX-LLM.

@jason-dai
Copy link
Contributor

LGTM

@gc-fu gc-fu merged commit a3b007f into intel-analytics:main Mar 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-dai jason-dai jason-dai left review comments

@glorysdj glorysdj glorysdj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gc-fu @jason-dai @glorysdj