Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fschat DEP version error #10325

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix fschat DEP version error #10325

merged 1 commit into from
Mar 6, 2024

Conversation

Zephyr596
Copy link
Contributor

Description

Old versions of gradio_web_server.py and openai_api_server.py will conflict with the new versions of gradio and pydantic.
We should use the latest version of fschat.

2. User API changes

None

3. Summary of the change

In this line:
https://github.com/intel-analytics/BigDL/blob/90be0f947b6a6c4b5925a96cc6bf9fdc610832f6/docker/llm/serving/cpu/docker/Dockerfile#L15
We install fschat with:
https://github.com/intel-analytics/BigDL/blob/90be0f947b6a6c4b5925a96cc6bf9fdc610832f6/python/llm/setup.py#L56
So update with latest version.

@Zephyr596 Zephyr596 requested review from Zhengjin-Wang and gc-fu March 5, 2024 07:25
@gc-fu
Copy link
Contributor

gc-fu commented Mar 6, 2024

What is the version of gradio?

@Zephyr596
Copy link
Contributor Author

What is the version of gradio?

=4.10
https://github.com/lm-sys/FastChat/blob/d04ce6453ae016d9e03626b679c07aa1388dcbee/pyproject.toml#L23
In fact, it was:
image

@gc-fu
Copy link
Contributor

gc-fu commented Mar 6, 2024

Have you tested this in CPU and XPU platforms?

@gc-fu gc-fu requested a review from liu-shaojun March 6, 2024 01:13
Copy link
Contributor

@gc-fu gc-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zephyr596
Copy link
Contributor Author

Have you tested this in CPU and XPU platforms?

In XPU: if use bigdl-llm version after 2.5.0b20240229, bigdl.llm.serving.model_worker can not work.

@Zephyr596 Zephyr596 merged commit 46f0f10 into intel-analytics:main Mar 6, 2024
19 checks passed
liu-shaojun pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants