Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use factory methods to create layers instead of calling the constructor directly #3

Closed
yiheng opened this issue Sep 9, 2016 · 0 comments
Assignees

Comments

@yiheng
Copy link
Contributor

yiheng commented Sep 9, 2016

When defining a model, instead of directly calling the constructors of individual modules, we should use factory methods (e.g., through Scala companion object’s apply methods). This allows one to define the same model that can run using different underlying engine (e.g., MKL-DNN).

@yiheng yiheng closed this as completed Dec 7, 2016
wzhongyuan pushed a commit to wzhongyuan/BigDL that referenced this issue Aug 28, 2017
* add python notebook support

* put post process calculation into executors
yangw1234 added a commit that referenced this issue Nov 25, 2021
* add github action for nano code style (#1)

* Update nano-style-check.yml

* Test pr (#2)

* change something

* make style break

* Update nano-style-check.yml

* Update nano-style-check.yml (#3)

* Update nano-style-check.yml

* Update nano-style-check.yml

* Update nano-style-check.yml

* Update nano-style-check.yml

* Update nano-style-check.yml

* Update nano-style-check.yml

* fix style

* change nane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants