Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for ray psutil on macOS #2856

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Hotfix for ray psutil on macOS #2856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbeeee7
Hotfix for ray psutil on macOS
qiyuangong Sep 11, 2020
7ebd0dd
Add try except to catch AccessDenied
qiyuangong Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions pyzoo/zoo/ray/raycontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,22 @@ def kill_redundant_log_monitors(redis_address):
import subprocess
log_monitor_processes = []
for proc in psutil.process_iter(["name", "cmdline"]):
cmdline = subprocess.list2cmdline(proc.cmdline())
is_log_monitor = "log_monitor.py" in cmdline
is_same_redis = "--redis-address={}".format(redis_address)
if is_log_monitor and is_same_redis in cmdline:
log_monitor_processes.append(proc)
try:
# Avoid throw exception when listing lwsslauncher in macOS
if proc.name() is None or proc.name() == "lwsslauncher":
continue
cmdline = subprocess.list2cmdline(proc.cmdline())
is_log_monitor = "log_monitor.py" in cmdline
is_same_redis = "--redis-address={}".format(redis_address)
if is_log_monitor and is_same_redis in cmdline:
log_monitor_processes.append(proc)
except psutil.AccessDenied:
# psutil may encounter AccessDenied exceptions
# when it's trying to visit core services
if psutil.MACOS:
continue
else:
raise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise what?


if len(log_monitor_processes) > 1:
for proc in log_monitor_processes[1:]:
Expand Down