Inference Model string support of TFNet #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide some descriptions/unit tests on how the user is supposed to use this features? E.g., what the user input looks like when sending the requests to cluster serving. |
jason-dai
reviewed
Jun 15, 2020
| val sampleKey = inputActivity.toTable.keySet.head | ||
| inputActivity.toTable(sampleKey).asInstanceOf[Tensor[Float]].size(1) | ||
| } | ||
| // val batchSize = if (inputActivity.isTensor) { |
jason-dai
reviewed
Jun 15, 2020
| import com.intel.analytics.zoo.serving.utils.{ClusterServingHelper, SerParams} | ||
| import org.scalatest.{FlatSpec, Matchers} | ||
|
|
||
| class InferenceSpec extends FlatSpec with Matchers { |
There was a problem hiding this comment.
is this testing anything?
There was a problem hiding this comment.
This is TODO, nothing is tested so far, this need some string schema currently unknown, will check.
jason-dai
reviewed
Jun 15, 2020
| if "string" in key: | ||
| # list of string will be converted to Tensor of String | ||
| # use | to split | ||
| str_concat = '|'.join(value) |
There was a problem hiding this comment.
what if there is '|' in the original strings?
There was a problem hiding this comment.
Will check schema, if so, will change to another one.
qiyuangong
changed the title
This will update to doc |
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 20, 2021
Noted InferenceModel predict batchSize is removed
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 26, 2021
Noted InferenceModel predict batchSize is removed
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 27, 2021
Noted InferenceModel predict batchSize is removed
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 30, 2021
Noted InferenceModel predict batchSize is removed
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Aug 7, 2021
Noted InferenceModel predict batchSize is removed
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Aug 9, 2021
Noted InferenceModel predict batchSize is removed
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Aug 9, 2021
Noted InferenceModel predict batchSize is removed
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 10, 2021
Noted InferenceModel predict batchSize is removed
Litchilitchy
pushed a commit
to Litchilitchy/analytics-zoo
that referenced
this pull request
Sep 23, 2021
Noted InferenceModel predict batchSize is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One feature lost for this PR, inferenceModel could not print batchSize anymore, user should print them by themselves before input the Tensor to model.