add weightdecay to Adam #2415
Merged
add weightdecay to Adam #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins passed |
hkvision
reviewed
Jul 13, 2020
| val schedule: LearningRateSchedule = Default() | ||
| )(implicit ev: TensorNumeric[T]) extends SGD[T](learningRate = lr, | ||
| learningRateDecay = decay, learningRateSchedule = schedule) { | ||
| learningRateDecay = decay, weightDecay = wDecay, learningRateSchedule = schedule) { |
There was a problem hiding this comment.
Why don't you directly pass weightDecay to it parent class SGD so that you can directly extend SGD's implementation?
|
jenkins passed |
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 19, 2021
* add weightdecay * revert * some change * some update * some update
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 20, 2021
* add weightdecay * revert * some change * some update * some update
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 26, 2021
* add weightdecay * revert * some change * some update * some update
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 30, 2021
* add weightdecay * revert * some change * some update * some update
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Jul 30, 2021
* add weightdecay * revert * some change * some update * some update
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Aug 7, 2021
* add weightdecay * revert * some change * some update * some update
dding3
pushed a commit
to dding3/analytics-zoo
that referenced
this pull request
Aug 9, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 2, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 2, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 2, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 3, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 3, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 7, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 7, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 8, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 9, 2021
* add weightdecay * revert * some change * some update * some update
Le-Zheng
pushed a commit
to Le-Zheng/analytics-zoo
that referenced
this pull request
Sep 13, 2021
* add weightdecay * revert * some change * some update * some update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add weightdecay to adam, this implement is similiar with pytorch adam