-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BERTSQuAD and BERTNER #1401
Conversation
@yangw1234 Take a look at the changes to your code? |
@@ -224,8 +224,9 @@ def _get_arguments_from_loss(loss, optim_method, session, val_outputs, val_label | |||
variables = [] | |||
grads = [] | |||
for (grad, var) in grads_vars: | |||
variables.append(var) | |||
grads.append(grad) | |||
if grad is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
synced with @yangw1234 for this change offline.
estimator part looks good to me |
jenkins passed: http://10.239.47.211:18888/job/ZOO-PR-Validation/2357/ |
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
* add bert squad code * modify grad clip * revert * fix style * init ner * update examples * minor update * remove examples * revert adamweightdecay * update * add ut
@jason-dai Please take a look.