Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BERTSQuAD and BERTNER #1401

Merged
merged 11 commits into from
Jun 11, 2019
Merged

Conversation

hkvision
Copy link
Contributor

@hkvision hkvision commented May 28, 2019

  • Some enhancement and bug fixes.
  • Add BERTSQuAD
  • Will remove the examples afterwards.
  • Optimizer based on intel-analytics/analytics-zoo#1336
    @jason-dai Please take a look.

@hkvision hkvision requested a review from jason-dai May 28, 2019 06:33
@hkvision hkvision added the text label May 28, 2019
@hkvision
Copy link
Contributor Author

@yangw1234 Take a look at the changes to your code?

@hkvision hkvision requested a review from yangw1234 May 30, 2019 08:45
@hkvision hkvision changed the title Support BERTSQuAD Support BERTSQuAD and BERTNER May 31, 2019
@@ -224,8 +224,9 @@ def _get_arguments_from_loss(loss, optim_method, session, val_outputs, val_label
variables = []
grads = []
for (grad, var) in grads_vars:
variables.append(var)
grads.append(grad)
if grad is not None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synced with @yangw1234 for this change offline.

@yangw1234
Copy link
Contributor

estimator part looks good to me

@hkvision
Copy link
Contributor Author

jenkins passed: http://10.239.47.211:18888/job/ZOO-PR-Validation/2357/
Merge this first as the code becomes messy. Feel free to raise further comments if any.

@hkvision hkvision merged commit 416a7d4 into intel-analytics:master Jun 11, 2019
@hkvision hkvision deleted the bert-squad branch June 11, 2019 10:41
dding3 pushed a commit to dding3/analytics-zoo that referenced this pull request Jul 30, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
dding3 pushed a commit to dding3/analytics-zoo that referenced this pull request Jul 30, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
dding3 pushed a commit to dding3/analytics-zoo that referenced this pull request Jul 30, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
dding3 pushed a commit to dding3/analytics-zoo that referenced this pull request Sep 8, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
dding3 pushed a commit to dding3/analytics-zoo that referenced this pull request Sep 8, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
shanyu-sys pushed a commit to shanyu-sys/analytics-zoo that referenced this pull request Sep 10, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
yangw1234 pushed a commit to yangw1234/analytics-zoo that referenced this pull request Sep 24, 2021
* add bert squad code

* modify grad clip

* revert

* fix style

* init ner

* update examples

* minor update

* remove examples

* revert adamweightdecay

* update

* add ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants