Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonc-parser): do not trim empty lines by JSONC formatter #60

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

ma-zal
Copy link
Collaborator

@ma-zal ma-zal commented May 25, 2023

Issue

JSONC formatter is removing all empty lines in documents.

Root cause

Lib node-jsonc-parser, method format(). There was similar issue in VS Code, which has been already solved by adding option keepLines into this lib.

Solution

Upgrade node-jsonc-parser and set keepLines flag.

Testing

Updated extension tested on my local machine in VS Code. Works.

Relates links

@ma-zal ma-zal requested a review from dominikkadera May 25, 2023 07:38
Copy link
Member

@dominikkadera dominikkadera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please fix the blank characters in the CHANGELOG.md, I've left there a comment -- currently, they break the markdown 😅

Otherwise, it's pretty clear 😁

CHANGELOG.md Outdated Show resolved Hide resolved
@ma-zal ma-zal requested a review from dominikkadera May 30, 2023 18:14
Copy link
Member

@dominikkadera dominikkadera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looking great now, thanks 😁

@ma-zal ma-zal merged commit ba536a7 into development Jun 5, 2023
@ma-zal ma-zal deleted the feat/json-keepLines branch June 5, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants