Upgrade substrate to 7406442bea0194ffcafc4e8d48d895d4d8d11346 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Please don't merge for now. |
clangenb
approved these changes
Dec 2, 2021
| loop { | ||
| let ret: ProcessedParentchainBlockArgs = _chain_api | ||
| .wait_for_event::<ProcessedParentchainBlockArgs>( | ||
| TEEREX, | ||
| "ProcessedParentchainBlock", | ||
| Some(decoder.clone()), | ||
| None, |
There was a problem hiding this comment.
Good point, this is obsolete in the api-client. I need to remove that arg.
| pub fn grandpa_log<Block: BlockT>( | ||
| digest: &DigestG<HashFor<Block>>, | ||
| ) -> Option<ConsensusLog<NumberFor<Block>>> { | ||
| pub fn grandpa_log<Block: BlockT>(digest: &DigestG) -> Option<ConsensusLog<NumberFor<Block>>> { |
There was a problem hiding this comment.
Please rename the import to just Digest. The G stands for generic, which is not the case anymore.
haerdib
approved these changes
Dec 2, 2021
| let id = OpaqueDigestItemId::Consensus(&GRANDPA_ENGINE_ID); | ||
| digest.convert_first(|l| l.try_to::<ConsensusLog<NumberFor<Block>>>(id)) | ||
| } | ||
|
|
||
| pub fn pending_change<Block: BlockT>( | ||
| digest: &DigestG<HashFor<Block>>, | ||
| digest: &DigestG, |
There was a problem hiding this comment.
Same as clangenbs comment above: Remove G
added 2 commits
December 6, 2021 11:34
Compile with error duplicate lang item in crate `sgx_tstd` Sgx runtime upgraded to new substrate, but has extrinsics-factory errors. Upgrade works, problem in substrate-api-client fixed in version #a4d931c85f30ba22ff1f982c47caf57fe43ebc90 Rebase to master and update changes to new substrate cargo clippy Remove patch to local dependencies Remove comments Update spec version to 4 Changes from review
echevrier
force-pushed
the
ec_upgrade_substrate_v14metadata
branch
from
4c2cbec to
820d72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility reason, the node requiring V14 metadata integritee-network/integritee-node#83
merge upgraded node first upgrade substrate dep to > v14 metadata integritee-node#85 and update worker CI to use this node.
merge upgraded sgx-runtime Upgrade to substrate 7406442bea0194ffcafc4e8d48d895d4d8d11346 sgx-runtime#39