-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shutdown upon parentchain code update #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a legit approach to me, given the caveats we are aware of that you mentioned.
field test almost successful. Paseo had a runtime upgrade today: the worker did shut down:
and restart:
from then on, the validateer was stuck (rpc did respond!) and needed a manual restart. See #1647 |
closes #1633
code updates can cause extrinsics to fail unless we can update metadata and extrinsics
AdditionalParams
.Our architecture currently doesn't allow to update these dynamically.
Shutting down the service gracefully (assuming automatic restart) is safe and clean and probably doesn't even cause additional downtime as we would need to pause TOP's anyway to avoid race conditions
caveat: