Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache MRENCLAVE during ocall as lazy static #1437

Merged
merged 8 commits into from
Sep 14, 2023
Merged

cache MRENCLAVE during ocall as lazy static #1437

merged 8 commits into from
Sep 14, 2023

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Sep 5, 2023 •
edited
Loading

closes #1405

inspired by https://blog.sentry.io/you-cant-rust-that/

  • this is expected to fix our flaky M6 integration tests which are over-stressing AESMD service
  • a slight performance optimization can be expected as well as we don't lose time with needless AESMD requests anymore

@brenzi
Copy link
Collaborator Author

brenzi commented Sep 12, 2023

@clangenb can you quickly confirm that I'm on the right track here?

@brenzi brenzi added A0-core Affects a core part B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" F7-optimization E0-breaksnothing labels Sep 13, 2023
@brenzi brenzi marked this pull request as ready for review September 13, 2023 18:38
@brenzi brenzi requested a review from clangenb September 13, 2023 18:38
clangenb
clangenb approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, minimal change, huge impact.

@brenzi brenzi merged commit 3d257de into master Sep 14, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
A0-core Affects a core part B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing F7-optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avoid triggering an entire sgx report creation just to know mrenclave
2 participants
@brenzi @clangenb