integrate pallet teerex refactoring #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [local-setup] fix setup with two workers: avoid using the same data dirs. (#1358) * [ita_stf/test_genesis] remove reserved balance from state, as it doesn't exist anymore * [enclave-runtime/top_pool_execution] downgrade logs to trace * [state_handler] add debug and trace logs * add additional flags for the worker setup * [its-consensus-aura/block_importer] add some more logs * local setup add some more logging
|
I think the flaky M6 test might be mitigated by #1405 |
brenzi
commented
Aug 5, 2023
brenzi
commented
Aug 5, 2023
| ) -> Result<Vec<AuthorityId<P>>, ConsensusError> | ||
| where | ||
| ValidateerFetcher: ValidateerFetch + EnclaveOnChainOCallApi, | ||
| P: Pair, | ||
| P::Public: UncheckedFrom<[u8; 32]>, |
There was a problem hiding this comment.
Authorities as well are too generic IMO. We could use the same itp_types::AccountId type strictly
too much trait bound jungle here
brenzi
commented
Aug 5, 2023
| @@ -881,16 +915,36 @@ fn enclave_account<E: EnclaveBase>(enclave_api: &E) -> AccountId32 { | |||
| } | |||
|
|
|||
| /// Checks if we are the first validateer to register on the parentchain. | |||
| fn we_are_primary_validateer( | |||
| fn we_are_primary_worker( | |||
There was a problem hiding this comment.
this logic has now changed to something more meaningful. Instead of testing if we are the first enclave to have ever registered on this chain ( which would allow only a single sidechain to ever exist) we now check shard_status and see if some other enclave than self has ever touched that shard
|
@clangenb there may be quite some additional cleanup left after this PR as a consequence, but I thought the PR is big enough already. |
clangenb
reviewed
Aug 6, 2023
core-primitives/node-api/api-client-extensions/src/pallet_teerex.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: clangenb <[email protected]>
3 tasks
clangenb
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1384
Merge this first:
done: