Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from ias to dcap #1375

Merged
merged 74 commits into from
Jul 17, 2023
Merged

Switch from ias to dcap #1375

merged 74 commits into from
Jul 17, 2023

Conversation

mosonyi
Copy link
Contributor

@mosonyi mosonyi commented Jun 21, 2023

This PR tries to fix the issue #1240 , use dcap attestation in CI

@mosonyi mosonyi added B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing A7-somethingelse labels Jun 21, 2023
@OverOrion OverOrion mentioned this pull request Jun 28, 2023
Closed
OverOrion added 19 commits July 7, 2023 10:14
@OverOrion
build: revert dcap lib linking
3da293a
@OverOrion
build: revert cargo verbosity
6c57018
@OverOrion
docker: remove epid leftover files
7ae7998
@OverOrion
attestation-handler: return error if base64 decoding fails
85efade
@OverOrion
docker: fix typo in network name
a0273b6
@OverOrion
local-setup: print worker command as well
766469f
@OverOrion
dcap with sw mode: fix
df7fa3a
@OverOrion
gha/build: remove worker_features_arg
5d0ea05
@OverOrion
dcap with sw mode: fix integration tests
8ff7d52
@OverOrion
cli: add a note regarding dcap
8034e58
@OverOrion
clippy: fix
d32aecc
@OverOrion
mura: fix dcap related parameter references
3acf659
@OverOrion
fixup! mura: fix dcap related parameter references
967bc33
@OverOrion
docker: enable debug logging
1681a81
@OverOrion
add more logs
f141e03
@OverOrion
fixup! add more logs
28620c6
@OverOrion
mura: make sure enclave gets the correct reference
cd1784f
@OverOrion
Revert "docker: enable debug logging"
1d9b1db 
This reverts commit 1681a81.
@OverOrion
Revert "add more logs"
80f3a7e 
This reverts commit f141e03.
@OverOrion OverOrion requested a review from clangenb July 12, 2023 14:15
clangenb
clangenb approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this needed quite some fixes after all! Happy that it works now, I have some minor questions, but I will already approve!

core-primitives/attestation-handler/Cargo.toml Show resolved Hide resolved
core-primitives/attestation-handler/src/attestation_handler.rs Show resolved Hide resolved
core-primitives/attestation-handler/src/attestation_handler.rs Show resolved Hide resolved
core-primitives/attestation-handler/src/cert.rs Outdated Show resolved Hide resolved
enclave-runtime/src/attestation.rs Outdated Show resolved Hide resolved
@brenzi
Copy link
Collaborator

brenzi commented Jul 17, 2023

ignoring the flaky M6 test because it ran through and only trivial changes followed

@brenzi brenzi merged commit 3443f15 into master Jul 17, 2023
@clangenb clangenb mentioned this pull request Aug 1, 2023
Open
@clangenb clangenb deleted the zm/dcapci branch August 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverOrion OverOrion OverOrion left review comments

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
A7-somethingelse B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mosonyi @brenzi @OverOrion @clangenb