-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new shell spec for unbricking our parachain #78
Conversation
"integritee-rococo-fresh" => Box::new(integritee_chain_spec(para_id, GenesisKeys::Integritee, RelayChain::Rococo)), | ||
"integritee-rococo" => Box::new(integritee_rococo_config()?), | ||
// live configs (hard coded genesis state. genesis will always be shell for a live system) | ||
"integritee-rococo" => Box::new(shell_rococo_config()?), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may seem like a mistake, but integritee-*
will always have it's genesis derived from the shell-*
config. So I didn't see a reason to hard-code shell-<relaychain>
AND integritee-relaychain
. much more intuitive to only use the latter for live systems.
This, however, will require to rename the hardcoded spec from "Integritee Shell" to "Integritee Network" but I guess that step merits a new release anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosonyi this also means our live deployment will always use --chain integritee-kusama
after our upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, noted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. The integritee-hardcoded spec was essentially useless...
"chain_id": "integritee-kusama", | ||
"para_id": 2015, | ||
} | ||
"integritee-rococo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paraid not needed anymore
os.remove(f'{new_file_base}.state') | ||
os.remove(f'{new_file_base}.wasm') | ||
|
||
|
||
if __name__ == '__main__': | ||
parser = argparse.ArgumentParser() | ||
parser.add_argument('--migrate-genesis', help='Create entirely new chain spec, not preserving previous genesis state', action='store_true') | ||
parser.add_argument('--regenesis', help='Overwrite genesis state in chain spec. Use this for resetting chains entirely', action='store_true') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this I just copied over from encointer which fixed the misunderstanding of the flag
public_from_ss58::<sr25519::Public>("5CcSd1GZus6Jw7rP47LLqMMmtr2KeXCH6W11ZKk1LbCQ9dPY") | ||
.into(), | ||
public_from_ss58::<sr25519::Public>("5FsECrDjBXrh5hXmN4PhQfNPbjYYwwW7edu2UQ8G5LR1JFuH") | ||
.into(), | ||
public_from_ss58::<sr25519::Public>("5HBdSEnswkqm6eoHzzX5PCeKoC15CCy88vARrT8XMaRRuyaE") | ||
.into(), | ||
public_from_ss58::<sr25519::Public>("5GGxVLYTXS7JZAwVzisdXbsugHSD6gtDb3AT3MVzih9jTLQT") | ||
.into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes #65
const LOCAL_PARA_ID: u32 = 2000; | ||
const ROCOCO_PARA_ID: u32 = 2073; | ||
const WESTEND_PARA_ID: u32 = 2081; | ||
const KUSAMA_PARA_ID: u32 = 2015; | ||
const POLKADOT_PARA_ID: u32 = 2039; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was overdue. as we can't select our paraid ourselves, here are all the reserved id's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test, but looks good to me.
"integritee-rococo-fresh" => Box::new(integritee_chain_spec(para_id, GenesisKeys::Integritee, RelayChain::Rococo)), | ||
"integritee-rococo" => Box::new(integritee_rococo_config()?), | ||
// live configs (hard coded genesis state. genesis will always be shell for a live system) | ||
"integritee-rococo" => Box::new(shell_rococo_config()?), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. The integritee-hardcoded spec was essentially useless...
* clean up chainspecs (similar to the cleanup in integritee-network/parachain#78) * prepare for rococo to become permanent test-parachain * tested teleport downwards and upwards successfully with https://github.com/encointer/encointer-parachain/tree/master/docs/downward-upward-native-token-tx and a rococo-local-with-launch setup
closes #65
part of #77
this PR shall build the basis of the to-be-reset genesis config for Kusama
tested
--chain integritee-kusama