Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polkadot 0.9.13 #60

Merged
merged 18 commits into from
Jan 17, 2022
Merged

Polkadot 0.9.13 #60

merged 18 commits into from
Jan 17, 2022

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Jan 12, 2022 •
edited
Loading

closes #54

TODO before merge:

@brenzi brenzi requested a review from clangenb January 13, 2022 07:12
@brenzi brenzi mentioned this pull request Jan 13, 2022
Closed
@brenzi
Copy link
Collaborator Author

brenzi commented Jan 13, 2022 •
edited
Loading

clippy doesn't like it, but mostly complains about upstream code. Do we really want to fix this?
In Encointer, we had disabled it. will do so here too

clangenb
clangenb reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

polkadot-parachains/src/cli.rs Show resolved Hide resolved
polkadot-parachains/src/service.rs Outdated Show resolved Hide resolved
polkadot-parachains/src/service.rs Outdated Show resolved Hide resolved
@brenzi brenzi merged commit cfd74e2 into master Jan 17, 2022
@clangenb clangenb deleted the polkadot-0.9.13 branch December 20, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to polkadot 0.9.13
2 participants
@brenzi @clangenb