Add license check #165
Merged
Add license check #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Niederb
commented
Oct 4, 2022
•
Niederb
commented
- Similar to the PR for the pallets repo
- Add license check to CI pallets#98
- Note that parachain is already licensed under GPL-3.0
- Unfortunately the generated license.html does not mention the classpath exception
- See Generated html report does not mention license exceptions EmbarkStudios/cargo-about#204
- If we want to use it as part of a binary release we probably should modify it manually
- The license check takes quite some time (3 min), but I cannot reproduce this on my machine. There it takes seconds
- The parachain build already takes a while so it's not that important, but for other repos this can be annoying.
Niederb
force-pushed
the
tn/add-license-check
branch
from
a66c8a7
to
3e6926a
Compare
haerdib
approved these changes
Oct 10, 2022
| "ISC", | ||
| "OpenSSL", | ||
| "Unicode-DFS-2016", | ||
| "Zlib", |
There was a problem hiding this comment.
So GPL licences allow that many more licences? (comparing to pallets https://github.com/integritee-network/pallets/blob/917dd4f241ea41a50231c1effb060ab38745ad7d/about.hbs)
clangenb
approved these changes
Oct 12, 2022
| - name: Run license check | ||
| # Explicitly use stable because otherwise cargo will trigger a download of | ||
| # the nightly version specified in rust-toolchain.toml | ||
| run: cargo +stable about generate about.hbs > license.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.