Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CD] add collator binary and runtime wasm artifacts to releases #37

Closed
brenzi opened this issue Aug 21, 2021 · 6 comments
Closed

[CD] add collator binary and runtime wasm artifacts to releases #37

brenzi opened this issue Aug 21, 2021 · 6 comments
Assignees

Comments

@brenzi
Copy link
Collaborator

brenzi commented Aug 21, 2021

When we release a new version of the parachain, GH actions should attach the following artifacts to the release:

  • collator binary (Build workflow > integritee-collator-...... )
  • runtime wasm (SRtool Build workflow > integritee-runtime)
mosonyi added a commit that referenced this issue Aug 25, 2021
mosonyi added a commit that referenced this issue Aug 25, 2021
mosonyi added a commit that referenced this issue Aug 26, 2021
mosonyi added a commit that referenced this issue Aug 26, 2021
mosonyi added a commit that referenced this issue Aug 27, 2021
mosonyi added a commit that referenced this issue Aug 27, 2021
@mosonyi
Copy link
Collaborator

mosonyi commented Aug 27, 2021

@brenzi
Copy link
Collaborator Author

brenzi commented Aug 29, 2021

what do I need to check?

@mosonyi
Copy link
Collaborator

mosonyi commented Aug 29, 2021

If the name of files and their content is good.

@brenzi
Copy link
Collaborator Author

brenzi commented Aug 30, 2021

In the release, the file is called integritee-collator and it is not compressed, so it's directly the binary. I think this is fine.
We'll need the runtime files too: shell-runtime, integritee-runtime

Polkadot also releases the binary polkadotwithout version or commit hash. But they add the runtime spec version to the filename of the runtime wasm. I think this makes a lot of sense. Can we easily extract that?

like: polkadot_runtime-v9090.compact.compressed.wasm

We'd want to extract this:

maybe have a glimpse at their CI, how they do it?

@brenzi
Copy link
Collaborator Author

brenzi commented Sep 7, 2021

can we close this?

@mosonyi
Copy link
Collaborator

mosonyi commented Sep 7, 2021

Yes, it's done.

@mosonyi mosonyi closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants