dcap all sgx statuses #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
added
E2-needs-state-migration
E0-breaksnothing
and removed
E0-breaksnothing
labels
clangenb
reviewed
Sep 13, 2023
Comment on lines
+552
to
+554
| #[cfg(test)] | ||
| println!("certificate chain is invalid: {:?}", e); | ||
| Error::CertificateChainIsInvalid |
There was a problem hiding this comment.
Don't we want to go with the approach you chose in the last pr and simply make this trace?
There was a problem hiding this comment.
I couldn't make it work with cargo test -- --nocapture. that's why I used println specifically here, to see the inner error which we swallow otherwise
There was a problem hiding this comment.
You need to initialize the (env) logger in each test to make this work.
There was a problem hiding this comment.
|
@clangenb if you can live with my responses, please approve and resolve the comments. or insist ;-) |
clangenb
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217
added one unit test to check outdated status. we could certainly be more thorough with unit testing all possible combinations of tcb info with various quotes. But I guess for now this does test the new feature minimally