Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce pallet utility and re-run benchmark #75

Merged
merged 5 commits into from
Oct 16, 2021
Merged

introduce pallet utility and re-run benchmark #75

merged 5 commits into from
Oct 16, 2021

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Oct 14, 2021

fixes #72
benchmarked on devsgx02

Alain Brenzikofer added 2 commits October 14, 2021 17:46
@brenzi brenzi requested a review from clangenb October 14, 2021 15:51
clangenb
clangenb reviewed Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, the rest looks good.

I am surprised that the weights are very similar to my laptop.

runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/weights/frame_system.rs Show resolved Hide resolved
clangenb
clangenb approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will still approve, so you can merge after the tiny fix.

@brenzi brenzi merged commit 56ddfc7 into master Oct 16, 2021
@clangenb clangenb deleted the add-utility-pallet branch November 3, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include utility pallet
2 participants
@brenzi @clangenb