Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add callout on github app incompatibility #818

Merged
merged 1 commit into from
Jun 18, 2021
Merged

docs: add callout on github app incompatibility #818

merged 1 commit into from
Jun 18, 2021

Conversation

loozhengyuan
Copy link
Contributor

Fixes #817

@loozhengyuan
Copy link
Contributor Author

I've added a callout for the github_app_installation_repository resource for now but will be looking at the rest of the data sources and resources to see what else uses endpoints that are incompatible with GitHub Apps. If anyone knows of any, feel free to indicate here.

jcudit
jcudit approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good information to surface 👍🏾

@jcudit jcudit added this to the v4.12.0 milestone Jun 15, 2021
@loozhengyuan loozhengyuan marked this pull request as ready for review June 15, 2021 13:11
@loozhengyuan
Copy link
Contributor Author

@jcudit Quick update, I did a quick run through of the docs and it seems that this is the only resource that is incompatible. If you know of more, I can add on to this. Otherwise, I think this can be considered as ready.

@jcudit jcudit merged commit 1cf534a into integrations:master Jun 18, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@loozhengyuan
docs: add callout on github app incompatibility (integrations#818)
8e502e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcudit jcudit jcudit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.12.0
Development

Successfully merging this pull request may close these issues.

docs: improve GitHub Apps compatibility info
2 participants
@loozhengyuan @jcudit