validate actions secret names #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, @bendrucker! I really like this feature - adding error messages is a positive step forward in user friendliness, and the implementation looks OK to me. |
jcudit
approved these changes
Mar 12, 2021
k24dizzle
pushed a commit
to lyft/terraform-provider-github
that referenced
this pull request
Mar 16, 2021
* validate actions secret names * remove duplicate case
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* validate actions secret names * remove duplicate case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the secret naming rules described in the GitHub docs:
https://docs.github.com/en/actions/reference/encrypted-secrets#naming-your-secrets
Currently, if a user supplies an invalid secret name, it will be rejected at apply time:
Instead, this makes naming violations raise a clear error at validate/plan time. I've added unit tests against the validation function, similar to how other shared validation functions are handled. Happy to add a full acceptance test for an invalid case if that's of interest.