Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Example Directory And Collaboration Example #477

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Add Example Directory And Collaboration Example #477

merged 3 commits into from
Jun 9, 2020

Conversation

jcudit
Copy link
Contributor

@jcudit jcudit commented May 30, 2020

This was useful for reproducing a bug. We can add missing examples as bugs are fixed.

/cc https://github.com/terraform-providers/terraform-provider-github/issues/469

@ghost ghost added the size/M label May 30, 2020
@jcudit jcudit requested review from anGie44 and paultyng May 30, 2020 14:23
anGie44
anGie44 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments to possibly add to the docs but otherwise LGTM @jcudit

examples/repository_collaborator/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@jcudit jcudit added this to the v2.8.1 milestone Jun 3, 2020
@jcudit jcudit merged commit 187a280 into master Jun 9, 2020
@jcudit jcudit deleted the example-collaborator branch June 9, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anGie44 anGie44 anGie44 approved these changes

@paultyng paultyng Awaiting requested review from paultyng

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
v2.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jcudit @anGie44