Fix Failing CI Tests #393
Merged
Fix Failing CI Tests #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`golangci-lint run` fais to execute because of missing vendored dependencies.
ghost
added
added 4 commits
March 25, 2020 10:24
> SA5011: possible nil pointer dereference (staticcheck)
> SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
Refactor the error catching logic and be explicit about checking for a nil pointer.
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…er-failures Fix Failing CI Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes minor errors that were causing linter failures during CI runs.
3 / 4 errors were removed but one remains that I suspect will go away after automation kicks in for the next release. See here for more details around the remaining failure.
cc https://github.com/terraform-providers/terraform-provider-github/pull/362 (fb14221)